Update netdata.sh

code refactoring

misc/netdata.sh

@@ -5,6 +5,7 @@
 # License: MIT
 # https://github.com/tteck/Proxmox/raw/main/LICENSE
 
+function header_info {
     clear
     cat <<"EOF"
     _   __     __  ____        __
@@ -14,10 +15,33 @@ cat <<"EOF"
 /_/ |_/\___/\__/_____/\__,_/\__/\__,_/
 
 EOF
+}
+
+YW=$(echo "\033[33m")
+BL=$(echo "\033[36m")
+RD=$(echo "\033[01;31m")
+GN=$(echo "\033[1;92m")
+CL=$(echo "\033[m")
+BFR="\\r\\033[K"
+HOLD="-"
+CM="${GN}✓${CL}"
+silent() { "$@" >/dev/null 2>&1; }
+set -e
+header_info
+
+function msg_info() {
+  local msg="$1"
+  echo -ne " ${HOLD} ${YW}${msg}..."
+}
+
+function msg_ok() {
+  local msg="$1"
+  echo -e "${BFR} ${CM} ${GN}${msg}${CL}"
+}
 
 install() {
   while true; do
-  read -p "This script will install NetData on Proxmox VE 8+. Proceed(y/n)?" yn
+    read -p "Are you sure you want to install NetData on Proxmox VE host. Proceed(y/n)?" yn
     case $yn in
     [Yy]*) break ;;
     [Nn]*) exit ;;
@@ -25,24 +49,47 @@ while true; do
     esac
   done
 
+  read -r -p "Verbose mode? <y/N> " prompt
+  if [[ ${prompt,,} =~ ^(y|yes)$ ]]; then
+  STD=""
+  else
+  STD="silent"
+  fi
+  header_info
+  
+  msg_info "Setting up repository"
   wget -q https://repo.netdata.cloud/repos/repoconfig/debian/bookworm/netdata-repo_2-2+debian12_all.deb
-dpkg -i netdata-repo_2-2+debian12_all.deb
+  $STD dpkg -i netdata-repo_2-2+debian12_all.deb
   rm -rf netdata-repo_2-2+debian12_all.deb
-apt-get update &>/dev/null
+  msg_ok "Set up repository"
-apt-get -y upgrade
+
-apt-get install -y netdata
+  msg_info "Installing Netdata"
-echo -e "\nInstalled NetData (http://$(hostname -I | awk '{print $1}'):19999)\n"
+  $STD apt-get update
+  $STD apt-get install -y netdata
+  msg_ok "Installed Netdata\n"
+  msg_ok "Completed Successfully!\n"
+  echo -e "\n Netdata should be reachable at${BL} http://$(hostname -I | awk '{print $1}'):19999 ${CL}\n"
 }
 
 uninstall() {
+  read -r -p "Verbose mode? <y/N> " prompt
+  if [[ ${prompt,,} =~ ^(y|yes)$ ]]; then
+  STD=""
+  else
+  STD="silent"
+  fi
+  header_info
+  
+  msg_info "Uninstalling Netdata"  
   systemctl stop netdata
-apt-get remove --purge -y netdata netdata-repo
+  rm -rf /var/log/netdata /var/lib/netdata /var/cache/netdata /etc/netdata/go.d
-rm -rf /var/log/netdata /var/lib/netdata /var/cache/netdata /etc/apt/sources.list.d/netdata.list
+  rm -rf /etc/apt/trusted.gpg.d/netdata-archive-keyring.gpg /etc/apt/sources.list.d/netdata.list
-rm -rf /etc/apt/trusted.gpg.d/netdata-archive-keyring.gpg
+  $STD apt-get remove --purge -y netdata netdata-repo
   systemctl daemon-reload
-apt autoremove -y
+  $STD apt autoremove -y
-userdel netdata
+  $STD userdel netdata
-  echo -e "\nRemoved NetData from Proxmox VE\n"
+  msg_ok "Uninstalled Netdata\n"
+  msg_ok "Completed Successfully!\n"
 }
 
 if ! pveversion | grep -Eq "pve-manager/(8\.[0-9])"; then